Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add on header a link to help for translations/localisation (old PR) #134

Closed
wants to merge 8 commits into from
Closed

Add on header a link to help for translations/localisation (old PR) #134

wants to merge 8 commits into from

Conversation

marcuspollio
Copy link
Contributor

@marcuspollio marcuspollio commented Sep 28, 2023 •
edited
Loading

Hi !
Here is a small update to header.php to include a wiki link for people interested to help in translations/localisation.
Adding the link to the wiki as the page has more information about translations overall than directly on Crowdin seems appropriate to me. What do you think ?

printscreen

marcuspollio and others added 3 commits September 28, 2023 14:02
@marcuspollio
Add on header a link to help for translations/localisation
8cc9271 
Hi !
Here is a small update to header.php to include a wiki link for people interested to help in translations/localisation.
Adding the link to the wiki as the page has more information about translations overall than directly on Crowdin seems appropriate to me. What do you think ?
@marcuspollio
Merge pull request #1 from marcuspollio/header-add-translations
46ae871 
Add on header a link to help for translations/localisation
@pre-commit-ci
[pre-commit.ci] auto fixes from pre-commit.com hooks
9a29325 
for more information, see https://pre-commit.ci
@luzpaz
Copy link
Collaborator

luzpaz commented Sep 28, 2023

Can you provide a screenshot of how this looks like ?

@marcuspollio
Copy link
Contributor Author

marcuspollio commented Sep 28, 2023 •
edited
Loading

Oulà ... !
Looks like the "pre-commit" messed with many files unrelated to my change.
Should I revert anything ?

First time using GitHub, sorry =D

@luzpaz
Copy link
Collaborator

luzpaz commented Sep 28, 2023

CC @kaktusus

@luzpaz
Copy link
Collaborator

luzpaz commented Sep 28, 2023 •
edited
Loading

Oulà ... ! Looks like the "pre-commit" messed with many files unrelated to my change. Should I revert anything ?

I think a dev can cherrypick and merge for you. But it's good to follow the contributor guidelines from here on out (https://freecad.github.io/DevelopersHandbook/gettingstarted/)

Edit: and thank you so much for you contribution!

Edit 2: #134 (comment)

@marcuspollio
Copy link
Contributor Author

marcuspollio commented Sep 28, 2023 •
edited
Loading

follow the contributor guidelines

Yeah, sure ! Will do next time. This change was so small I did the edit directly in GH...

Edit: and thank you so much for you contribution!

You're welcome ! One has to start somewhere... =D

@luzpaz
Copy link
Collaborator

luzpaz commented Sep 28, 2023 •
edited
Loading

Can you provide a screenshot of how this looks like ?

Edit 2: #134 (comment)

@marcuspollio
Copy link
Contributor Author

marcuspollio commented Sep 28, 2023 •
edited
Loading

Can you provide a screenshot of how this looks like ?

Thanks Luzpaz for your support.

I just updated the OP with a screenshot.

As I struggled a bit to find a way to open the php file locally, here is a small hint for anyone looking to open a website folder (FreeCAD Homepage for example) on his web browser without using Apache, XAMPP or others :

  1. download the repository (< > Code green button on Github) and unzip
  2. make sure php is installed (for me on GNU/Linux, I had to install "php8.1-cli" as of September 2023)
  3. go to my local copy of the website folder ("FreeCAD-Homepage-master" in this case)
  4. open the terminal at working-directory location and paste php -S 127.0.0.1:8000
  5. as there is an "index.php" file in the FreeCAD case, opening a new tab in your web browser with localhost:8000/ displays the web page correctly. If you want to reach a particular file, use localhost:8000/MyFile.php

Hope it helps other folks... And sorry for the off-topic XD

@luzpaz luzpaz mentioned this pull request Sep 28, 2023
Closed
@kaktusus
Copy link

CC @kaktusus

The idea seems interesting.

The work of a translator for the FreeCAD project can be carried out on two separate levels that are closely intertwined.
I'm thinking here of the GUI and Crowdin, and the documentation and Wiki.
Maybe instead of a single link, it would be worthwhile to prepare a small piece of content that would cover the topic in more detail and explain something.

@kaktusus
Copy link

@marcuspollio
I'll ask you to take a look at this thread at your leisure (it's about code formatting and problems arising for translators)
FreeCAD/FreeCAD-translations#275

I'm curious if you are a translator. 😉

@chennes
Copy link
Member

chennes commented Sep 29, 2023

@marcuspollio are you confident enough in your git skills to rebase to master and drop 9a29325? It should not longer be needed.

@marcuspollio marcuspollio closed this by deleting the head repository Sep 29, 2023
@marcuspollio
Copy link
Contributor Author

marcuspollio commented Sep 29, 2023 •
edited
Loading

Hi @chennes !
Well, as I'm still learning all of this, I'll start again from a fresh repo =D
Coming back later...
Submitted here

@marcuspollio marcuspollio changed the title Add on header a link to help for translations/localisation Add on header a link to help for translations/localisation (old PR) Oct 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yorikvanhavre yorikvanhavre Awaiting requested review from yorikvanhavre

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@marcuspollio @luzpaz @kaktusus @chennes